Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: instrumentation of @aws-sdk/client-* v3.723.0 and later now works #4398

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

trentm
Copy link
Member

@trentm trentm commented Jan 7, 2025

v3.723.0 and later of some aws-sdk-js v3 clients updated to use @smithy/smithy-client@4
which is part of what is instrumented.


TAV tests for client-s3, client-sns, and client-sqs started failing with the 3.723.0 version released earlier today.
E.g.: https://github.com/elastic/apm-agent-nodejs/actions/runs/12641762762/job/35224835256

$ npm info @aws-sdk/client-s3 time
...
  '3.716.0': '2024-12-19T20:06:49.540Z',
  '3.717.0': '2024-12-20T19:58:02.159Z',
  '3.721.0': '2025-01-02T20:07:43.217Z',
  '3.722.0': '2025-01-03T19:56:43.048Z',
  '3.723.0': '2025-01-06T20:58:42.380Z'

The interesting part of the diff of those versions:

-        "@smithy/core": "^2.5.5",
-        "@smithy/smithy-client": "^3.5.1",
+        "@smithy/core": "^3.0.0",
+        "@smithy/smithy-client": "^4.0.0",

       "engines": {
-        "node": ">=16.0.0"
+        "node": ">=18.0.0"
       }

v3.723.0 and later of some aws-sdk-js v3 clients updated to use `@smithy/smithy-client@4`
which is part of what is instrumented.
@trentm trentm requested a review from david-luna January 7, 2025 00:01
@trentm trentm self-assigned this Jan 7, 2025
Copy link
Member Author

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test tav

@trentm trentm merged commit ff08a11 into main Jan 7, 2025
199 checks passed
@trentm trentm deleted the trentm/aws-sdk-tav-failures branch January 7, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants