Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove functionbeat #41506

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Remove functionbeat #41506

merged 5 commits into from
Dec 11, 2024

Conversation

AndersonQ
Copy link
Member

@AndersonQ AndersonQ commented Nov 4, 2024 •
edited by jlind23
Loading

Proposed commit message

remove functionbeat

Starting at 9.0.0 functionbeat will not be released anymore. So this changes remove the functionbeat code.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

  • Functionbeat is no longer available

Author's Checklist

Dependencies:

How to test this PR locally

WIP

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 4, 2024
@AndersonQ AndersonQ self-assigned this Nov 4, 2024
@AndersonQ AndersonQ added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Nov 4, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 4, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @AndersonQ? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Nov 4, 2024
@AndersonQ AndersonQ added backport-skip Skip notification from the automated backport with mergify and removed backport-8.x Automated backport to the 8.x branch with mergify labels Nov 4, 2024
AndersonQ
AndersonQ commented Nov 7, 2024
View reviewed changes
dev-tools/cmd/update_go/update_go_version.go
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lint issues aren't related to this PR, thus I'm not planning to fix them.

@AndersonQ AndersonQ requested a review from pazone November 7, 2024 13:29
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 12, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 40745-remove-functionbeat upstream/40745-remove-functionbeat
git merge upstream/main
git push upstream 40745-remove-functionbeat

@AndersonQ AndersonQ force-pushed the 40745-remove-functionbeat branch from 59add13 to 98f3de2 Compare December 3, 2024 09:22
@AndersonQ AndersonQ force-pushed the 40745-remove-functionbeat branch from 98f3de2 to 06bddea Compare December 3, 2024 09:26
@AndersonQ AndersonQ mentioned this pull request Dec 4, 2024
Closed
2 tasks
@AndersonQ AndersonQ marked this pull request as ready for review December 9, 2024 14:20
@AndersonQ AndersonQ requested review from a team as code owners December 9, 2024 14:20
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@AndersonQ AndersonQ changed the title WIP: remove functionbeat Remove functionbeat Dec 9, 2024
@jlind23
Copy link
Collaborator

jlind23 commented Dec 9, 2024

Linter failures are not related to this PR.

@jlind23
Copy link
Collaborator

jlind23 commented Dec 9, 2024

@cmacknz functionbeat has been deprecated for quite some time already, does it still deserve a changelog entry?

@cmacknz
Copy link
Member

cmacknz commented Dec 9, 2024

Functionbeat is still available for download appearing on https://www.elastic.co/downloads/beats and https://www.elastic.co/downloads/beats/functionbeat. This means that:

  1. This deserves a changelog entry
  2. Those pages on elastic.co need to remove functionbeat
  3. There are likely parts of the unified release that expect functionbeat and those need to be removed before we merge this or we'll break the unified release eventually when the previous DRA artifacts expire.

@jlind23
Copy link
Collaborator

jlind23 commented Dec 9, 2024

  1. This deserves a changelog entry

I will create one right away.

  1. Those pages on elastic.co need to remove functionbeat

This pages should only be removed for 9.0 and all versions above. @nimarezainia to whom should I reach out to for this?

  1. There are likely parts of the unified release that expect functionbeat and those need to be removed before we merge this or we'll break the unified release eventually when the previous DRA artifacts expire.

This has already been taken care of by @AndersonQ

@cmacknz
Copy link
Member

cmacknz commented Dec 9, 2024

There are likely parts of the unified release that expect functionbeat and those need to be removed before we merge this or we'll break the unified release eventually when the previous DRA artifacts expire.
This has already been taken care of by @AndersonQ

I still see functionbeat in the beats artifact summary in the unified release though https://snapshots.elastic.co/9.0.0-f4176a12/summary-9.0.0-SNAPSHOT.html#beats

belimawr
belimawr approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@belimawr belimawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that's mostly removing code and I cannot find any reference to functionbeat any more (aside from changelog entries): LGTM.

@jlind23
Copy link
Collaborator

jlind23 commented Dec 10, 2024 •
edited
Loading

I still see functionbeat in the beats artifact summary in the unified release though https://snapshots.elastic.co/9.0.0-f4176a12/summary-9.0.0-SNAPSHOT.html#beats

@jmlrt you merged the release manager PR 20 hours ago so this is supposed to be fixed soon right? Or do we need to manually remove the one that were already pushed?

cc @alsayasneh

@jmlrt
Copy link
Member

jmlrt commented Dec 10, 2024 •
edited
Loading

I still see functionbeat in the beats artifact summary in the unified release though https://snapshots.elastic.co/9.0.0-f4176a12/summary-9.0.0-SNAPSHOT.html#beats

@jmlrt you merged the release manager PR 20 hours ago so this is supposed to be fixed soon right? Or do we need to manually remove the one that were already pushed?

cc @alsayasneh

@jlind23 https://snapshots.elastic.co/9.0.0-f4176a12/summary-9.0.0-SNAPSHOT.html#beats is from a build dating from December 3rd. https://github.com/elastic/unified-release/pull/1558 was merged 10 hours ago and the latest build doesn't include packetbeat functionbeat anymore: https://snapshots.elastic.co/9.0.0-8585ff93/summary-9.0.0-SNAPSHOT.html

@jlind23
Copy link
Collaborator

jlind23 commented Dec 10, 2024

latest build doesn't include packetbeat

@jmlrt You meant functionbeat right? 😄 Do we need to clean up old snapshot or they'll be cleaned up once they reach their expiration delay?

@cmacknz according to @jmlrt comment I think we are good to proceed here right?

@jmlrt
Copy link
Member

jmlrt commented Dec 10, 2024

@jmlrt You meant functionbeat right? 😄 Do we need to clean up old snapshot or they'll be cleaned up once they reach their expiration delay?

Indeed it's functionbeat 😅
Yes old snapshot will be cleaned following the bucket lifecycle policy (I think it's 1 month for snapshot)

@jlind23 jlind23 enabled auto-merge (squash) December 10, 2024 08:41
@jlind23 jlind23 requested review from a team and rdner and removed request for a team December 10, 2024 17:07
rowlandgeoff
rowlandgeoff approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@rowlandgeoff rowlandgeoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Buildkite pipeline and GH workflow changes look ok. The packaging pipeline can't be tested in a PR though, so please watch that carefully after this merges.
https://buildkite.com/elastic/beats-packaging-pipeline

@jlind23 jlind23 disabled auto-merge December 10, 2024 19:48
@jlind23 jlind23 merged commit fb93eee into elastic:main Dec 11, 2024
140 of 143 checks passed
@jlind23
Copy link
Collaborator

jlind23 commented Dec 11, 2024

@rowlandgeoff thanks for the heads up, packaging pipeline worked like a charm.

michalpristas pushed a commit to michalpristas/beats that referenced this pull request Dec 13, 2024
@AndersonQ @michalpristas
Remove functionbeat (elastic#41506)
0ba5059 
* Remove functionbeat
* Add changelog entry for functionbeat removal

---------

Co-authored-by: julienlind <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rowlandgeoff rowlandgeoff rowlandgeoff approved these changes

@belimawr belimawr belimawr approved these changes

@pazone pazone Awaiting requested review from pazone

@VihasMakwana VihasMakwana Awaiting requested review from VihasMakwana VihasMakwana is a code owner automatically assigned from elastic/elastic-agent-data-plane

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@AndersonQ AndersonQ

Labels
backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove functionbeat binaries
7 participants
@AndersonQ @elasticmachine @jlind23 @cmacknz @jmlrt @belimawr @rowlandgeoff