-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: drop init.d support and go-daemon binaries #41845
base: main
Are you sure you want to change the base?
Conversation
remove init.d scripts drop go-daemon dep and daemon binaries cleanup mage tasks
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
Similar to Elastic Agent, the Beats DEB and RPM packages need to be able to run as services and that there is no systemd unit file to do this makes me suspect this doesn't work. There are no tests of the DEB and RPM packages in CI here AFAIK. For Beats, we do have a reference system unit file and actually document so outside of those packages this should be fine https://github.com/elastic/elastic-agent/blob/54932dc7b46cdd0d16791e07b8fc5dd596efb129/dev-tools/packaging/templates/linux/systemd.unit.tmpl#L1 https://www.elastic.co/guide/en/beats/filebeat/current/running-with-systemd.html We do reference init.d directly in some documentation. https://www.elastic.co/guide/en/beats/filebeat/current/filebeat-starting.html. We should also remove those references. |
maybe I'm missing something but isn't the systemd service file available at beats/dev-tools/packaging/packages.yml Lines 58 to 60 in 583d345
|
Yes it exists, we just need to double check the RPM and DEB packages include and use it properly. They have not been looked at in a long time. |
Proposed commit message
remove init.d scripts
drop go-daemon dep and daemon binaries
cleanup mage task
init.d should not be needed on distros we support
According to go-daemon readme: "Go daemon is not needed on systems with systemd."
See https://www.elastic.co/support/matrix#matrix_os
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs