Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #41846) test: bind mount gomodcache to cache go dependencies #41871

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 3, 2024

Proposed commit message

try to speed up ci jobs integration tests
bind host go mod cache to container /go/pkg/mod

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs


This is an automatic backport of pull request #41846 done by [Mergify](https://mergify.com).

* test: bind mount gomodcache to cache go dependencies

try to speed up ci jobs integration tests

* test(metricbeat): do not make gomodcache readonly

* lint: replace ioutil usage

* test: fail on empty gomodcache

* test: rework cache bind approach

instead of binding the volume on each dockerfile, run the container
with the proper volume arg

* test: bind gomodcache in kubernetes runner

* test: sync the gomodcache with rsync and fix linter issues

can't really bind using hostpath in k8s

* test: rework bind approach with k8s runner

since it's a local cluster, use kind to bind the hostpath to the node
then bind the node path to the container path

* lint: remove unused imports

* lint: fix linter issues

(cherry picked from commit 9045642)
@mergify mergify bot requested a review from a team as a code owner December 3, 2024 19:31
@mergify mergify bot added the backport label Dec 3, 2024
@mergify mergify bot requested review from rdner and mauri870 and removed request for a team December 3, 2024 19:31
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 3, 2024
@botelastic
Copy link

botelastic bot commented Dec 3, 2024

This pull request doesn't have a Team:<team> label.

@kruskall kruskall merged commit 786fd7c into 8.x Dec 5, 2024
142 checks passed
@kruskall kruskall deleted the mergify/bp/8.x/pr-41846 branch December 5, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant