Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #42271) x-pack/metricbeat/module/sql: Add debug queries when merge_results: true #42285

Open
wants to merge 1 commit into
base: 8.x
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 10, 2025

Proposed commit message

Add debug queries when merge_results: true. No new configuration added to match the behaviour when merge_results: false. Previously, as it was multiple queries that results in merge of results, the query parameter was left entry and hence the field was omitted out when merge_results: true. Now, we will publish it from here. Users that want this can keep it and others who do not want it can drop it.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  • Test if queries are there when merge_results is set to true.

Related issues

Screenshots

  • When merge_results: false:

Screenshot 2025-01-10 at 12 01 56 PM Screenshot 2025-01-10 at 12 01 47 PM


  • When merge_results: true:
Screenshot 2025-01-10 at 11 59 52 AM
This is an automatic backport of pull request #42271 done by [Mergify](https://mergify.com).

@mergify mergify bot added the backport label Jan 10, 2025
@mergify mergify bot requested a review from a team as a code owner January 10, 2025 11:40
@mergify mergify bot assigned shmsr Jan 10, 2025
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 10, 2025
@github-actions github-actions bot added enhancement Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team labels Jan 10, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport enhancement Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant