Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logsdb snapshot functional tests #206318

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Logsdb snapshot functional tests #206318

wants to merge 2 commits into from

Conversation

SoniaSanzV
Copy link
Contributor

Part of #203716

Summary

This PR creates the tests for Logsdb in the Snapshot and Restore plugin

  • Verify that users can create snapshots from an LogsDB index.

  • Verify that users can restore a LogsDB snapshot.

  • Verify that users can NOT create a source-only snapshot from a LogsDB index [Snapshot result would be "Partial"].

  • Verify that users can NOT restore a source-only snapshot from a LogsDB index.

@SoniaSanzV SoniaSanzV added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Jan 10, 2025
@SoniaSanzV SoniaSanzV self-assigned this Jan 10, 2025
@SoniaSanzV SoniaSanzV marked this pull request as ready for review January 10, 2025 17:12
@SoniaSanzV SoniaSanzV requested review from a team as code owners January 10, 2025 17:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@SoniaSanzV SoniaSanzV mentioned this pull request Jan 10, 2025
Open
12 tasks
dmlemeshko
dmlemeshko reviewed Jan 10, 2025
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a question about privileges update

x-pack/test/functional/config.base.js
],
indices: [
{
names: ['*'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elastic docs states Index privilege "all" on the "monitor" index. Shouldn't we specify monitor instead of *?

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #38 / discover/security/context_awareness security root profile cell renderers host.name DataView mode should open host.name flyout

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
snapshotRestore 257.7KB 258.3KB +559.0B

cc @SoniaSanzV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlemeshko dmlemeshko dmlemeshko left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@SoniaSanzV SoniaSanzV

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SoniaSanzV @elasticmachine @dmlemeshko