Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "Examples" navigation link #26

Merged
merged 5 commits into from
May 12, 2021
Merged

feat: add "Examples" navigation link #26

merged 5 commits into from
May 12, 2021

Conversation

molant
Copy link
Contributor

@molant molant commented May 10, 2021

Add the top navigation link "Examples" and a new page that explains how
to acquire Fiddle and run the examples available in the sidebar.


Partial work on #2

@MarshallOfSound MarshallOfSound temporarily deployed to electronjsor-feat-examp-kpznml May 10, 2021 22:50 Inactive
@molant
Copy link
Contributor Author

molant commented May 10, 2021

This is how it looks like locally:

image

@molant molant requested a review from erickzhao May 10, 2021 22:51
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if instead of adding a whole doc on this, we should have a short admonition added to the existing how-to docs.

scripts/tasks/how-to-examples.md Outdated Show resolved Hide resolved
@molant molant temporarily deployed to electronjsor-feat-examp-kpznml May 11, 2021 17:12 Inactive
scripts/tasks/how-to-examples.md Outdated Show resolved Hide resolved
scripts/tasks/how-to-examples.md Outdated Show resolved Hide resolved
scripts/tasks/how-to-examples.md Outdated Show resolved Hide resolved
scripts/tasks/how-to-examples.md Outdated Show resolved Hide resolved
@molant molant temporarily deployed to electronjsor-feat-examp-kpznml May 12, 2021 12:31 Inactive
molant and others added 3 commits May 12, 2021 05:33
Add the top navigation link "Examples" and a new page that explains how
to acquire Fiddle and run the examples available in the sidebar.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Partial work on #2
Co-authored-by: Erick Zhao <[email protected]>
@molant molant temporarily deployed to electronjsor-feat-examp-kpznml May 12, 2021 12:35 Inactive
@molant molant requested a review from erickzhao May 12, 2021 12:36
scripts/tasks/how-to-examples.md Outdated Show resolved Hide resolved
Co-authored-by: Erick Zhao <[email protected]>
@molant molant temporarily deployed to electronjsor-feat-examp-kpznml May 12, 2021 17:09 Inactive
@molant molant temporarily deployed to electronjsor-feat-examp-kpznml May 12, 2021 18:25 Inactive
@molant molant merged commit eda594a into main May 12, 2021
@molant molant deleted the feat/examples branch May 12, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants