support Duration in Date.range/3
#14172
Open
+92
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfiedlerdejanze
force-pushed
the
date-range-with-durations
branch
from
72659ab to
7650afb
Compare
tfiedlerdejanze
changed the title
Duration in Date.range/3
tfiedlerdejanze
force-pushed
the
date-range-with-durations
branch
from
7650afb to
563fd96
Compare
josevalim
reviewed
Jan 10, 2025
| @@ -119,6 +124,11 @@ defmodule Date do | |||
| range(first, first_days, last, last_days, calendar, step) | |||
| end | |||
|
|
|||
| def range(%{calendar: calendar} = first, %Duration{} = duration) do | |||
There was a problem hiding this comment.
shall we allow the keyword list version as well? :)
There was a problem hiding this comment.
i found that range(~D[2020-01-01], [year: 1], 2) looks a bit unergonomic, but definitely nothing speaking against allowing it 👍
sabiwara
reviewed
Jan 10, 2025
lib/elixir/lib/calendar/date.ex
Outdated
| @@ -149,6 +159,11 @@ defmodule Date do | |||
| range(first, first_days, last, last_days, calendar, step) | |||
| end | |||
|
|
|||
| def range(%{calendar: calendar} = first, %Duration{} = duration, step) do | |||
There was a problem hiding this comment.
We should probably guard this too to check that step is a non-zero integer and update the ArgumentError clause & message?
josevalim
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.