Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify
html.js
by moving all init into modules.swup:page:view
callbacks from within modulesisEmbedded
,isPreview
andisHint
into globalsdescriptionElementFromHash
to also move comment nodes - preserving tabset commentsOne thing I noticed when refactoring the init logic:
Notice that the second
if
is not anelse if
even though it's formatted like one. I assume that it was intended to be anelse if
and have refactored it that way.By shuffling the module init and preventing a lot of unnecessary work, previews load almost 2x faster for me locally.
Before
After
-0.4kb JS