Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor array type handling in variable and JSON converters #6283

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

sfmskywalker
Copy link
Member

@sfmskywalker sfmskywalker commented Jan 10, 2025

Updated the logic to use MakeArrayType for array handling instead of generic collection types, ensuring consistency and better alignment with expected type structures. Adjustments were made in both the VariableDefinitionMapper and the TypeJsonConverter.


This change is Reviewable

Updated the logic to use `MakeArrayType` for array handling instead of generic collection types, ensuring consistency and better alignment with expected type structures. Adjustments were made in both the `VariableDefinitionMapper` and the `TypeJsonConverter`.
@sfmskywalker sfmskywalker merged commit e395361 into main Jan 10, 2025
2 of 3 checks passed
@sfmskywalker sfmskywalker deleted the fix/array-wf-type branch January 10, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant