#1611 Filter getPropertyValues() based on the selected tab

[nmgokhale]

Fixes #1611

Added a new config option getActiveTabControls for getPropertyValues() method in properties-controller.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

[matthoward366]

I would probably rename this to activeTabValues instead. getActiveTabControls makes me think this is a method.

[matthoward366]

Have you looked at this.panelTree? I think this already has a tree of all the panels and controls within a tree. Could we use that instead of having to parse it again?

[nmgokhale]

@matthoward366 this.panelTree works for most cases. But when "type": "subTabs",, the group doesn't show up under this.panelTree.

Example in tab_paramDef.json, Primary3 group has "type": "subTabs",. This group isn't listed under panelTree - https://github.com/elyra-ai/canvas/blob/main/canvas_modules/harness/test_resources/parameterDefs/tab_paramDef.json#L577

[matthoward366]

Should it be? Maybe the code for the panelTree parsing isn't handling this correctly? Seems like ui-groups-parser should doing what you're trying to do here.

[matthoward366]

The other question here is should document the method in the controller for getting the active tab then the consuming application should be able to do this to determine the parameters within that group.

[nmgokhale]

After discussion with DataStage team, they just need top level active tab's group id. Closing this PR. I will create a new PR for returning top level active tab group id.