-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema Changes for Slider Control #138
Schema Changes for Slider Control #138
Conversation
Signed-off-by: srikant <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srikant-ch5 How are you handling the min/max values in the slider?
Hi @matthoward366 Please review PR for the min/max I have handled it in paramdef. elyra-ai/canvas#1675 |
Signed-off-by: srikant <[email protected]>
Hi @matthoward366 Please review this schema for slider with min and max. |
@@ -293,6 +294,16 @@ | |||
"type": "number", | |||
"default": 1 | |||
}, | |||
"min": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe change these to min_value and max_value to make them a little clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, are you using increment? We might need to update the comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Matt, I have updated min_value and max_value and also updated increment description.
Signed-off-by: srikant <[email protected]>
"code", | ||
"list", | ||
"hidden" | ||
] | ||
}, | ||
"increment": { | ||
"description": "Determines the increment/decrement value for the spinner control only", | ||
"description": "Determines the step value to increment/decrement for the slider control", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be spinner and slider control.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I have updated accordingly.
Signed-off-by: srikant <[email protected]>
"code", | ||
"list", | ||
"hidden" | ||
] | ||
}, | ||
"increment": { | ||
"description": "Determines the increment/decrement value for the spinner control only", | ||
"description": "Determines the step value to increment/decrement for spinner and slider control", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor grammer update. Should be controls
Signed-off-by: srikant <[email protected]>
Developer's Certificate of Origin 1.1