Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema Changes for Slider Control #138

Merged
merged 5 commits into from
Jan 29, 2024

Conversation

srikant-ch5
Copy link
Contributor

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Copy link
Member

@matthoward366 matthoward366 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srikant-ch5 How are you handling the min/max values in the slider?

@srikant-ch5
Copy link
Contributor Author

srikant-ch5 commented Jan 24, 2024

@srikant-ch5 How are you handling the min/max values in the slider?

Hi @matthoward366 Please review PR for the min/max I have handled it in paramdef. elyra-ai/canvas#1675

@srikant-ch5
Copy link
Contributor Author

Hi @matthoward366 Please review this schema for slider with min and max.

@@ -293,6 +294,16 @@
"type": "number",
"default": 1
},
"min": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change these to min_value and max_value to make them a little clearer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, are you using increment? We might need to update the comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Matt, I have updated min_value and max_value and also updated increment description.

"code",
"list",
"hidden"
]
},
"increment": {
"description": "Determines the increment/decrement value for the spinner control only",
"description": "Determines the step value to increment/decrement for the slider control",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be spinner and slider control.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I have updated accordingly.

"code",
"list",
"hidden"
]
},
"increment": {
"description": "Determines the increment/decrement value for the spinner control only",
"description": "Determines the step value to increment/decrement for spinner and slider control",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor grammer update. Should be controls

@matthoward366 matthoward366 merged commit d8552fd into elyra-ai:main Jan 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants