-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Housekeeping for 0.7 #12
Conversation
Originally did this for the simulator screenshot collage but I think it looks nicer like this.
Rectangle intersection moved to embedded-graphics/debug-tools#9. |
A bit of a kitchen sink PR, but I think I've covered most points in the other issues in this repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of reviews
Co-authored-by: Ralf Fuest <[email protected]>
|
This is really a debug tool and is already sorted by the "line" example in embedded-graphics/debug-tools.
To address your points in order:
As for the licenses, I can use the same structure as the e-g repo. Let me do that quick... |
Licenses are added, MIT or Apache 2.0 the same as e-g. I also added them to the |
Some final comments:
|
Changes addressed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only one small issue left.
LICENSE-MIT
Outdated
Copyright (c) 2020 James Waples | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other creates in the Rust ecosystem (including the main rust repo) have removed this line from the MIT license. I think the TLDR was that each author retains the copyright to their contribution and that a global copyright is invalid anyway.
Copyright (c) 2020 James Waples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I've removed it from the license file.
Should we "fork" the eg-0.7 examples directory in this PR? Because the |
Ah, no, I think we should do that when 0.7 is released. Technically there's no proper release yet, so keeping |
OK. But I have to admit that finally seeing the |
Thanks for the reviews! These examples look really good now.
It did look spectacular! The quicker we can get the migration guide done the quicker we can release non-beta and go back to non-Git |
Progress towards #8 and #5, closes #7, closes #6.