Convert Existence Checks to Embroider Macros #8167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
added
🎯 canary
richgt
force-pushed
the
richgt/babel-plugin-existence-checks
branch
2 times, most recently
from
6daf31b to
9ed5b80
Compare
The fiddly details of manipulating import statements without clobbering any existing scope and while maintaining babel's bindings analysis are difficult to get right on the first try, which is why i made babel-import-util.
runspired
force-pushed
the
richgt/babel-plugin-existence-checks
branch
from
9ed5b80 to
1c10960
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create new Babel Transform to convert module existence checks to Embroider Macros.
for: #8103
Type of PR
What kind of change is this?
Notes for the release
Does this PR need to be described in the Ember release blog post? Please briefly describe what should be shared.
Probably not :-D