Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEVER MERGE] v4-main delta comparison #9622

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[NEVER MERGE] v4-main delta comparison #9622

wants to merge 1 commit into from

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Dec 19, 2024 •
edited
Loading

This PR exists purely to compare the delta between the main branch and the v4-main branch, so as to eliminate any unexpected differences before we continue with releasing 4.3 and 5.4

Generation command:

git fetch origin && git reset --hard origin/main && git checkout origin/v4-main . && git checkout origin/main pnpm-lock.yaml && git add -A && git commit -m "chore: generate latest delta" && git push origin/verify-v4-main -f

@runspired runspired changed the base branch from main to updates-from-v4 December 19, 2024 01:41
@runspired runspired changed the base branch from updates-from-v4 to main December 19, 2024 01:42
@runspired runspired force-pushed the verify-v4-main branch 19 times, most recently from d339eeb to 6a96074 Compare December 20, 2024 19:06
runspired
runspired commented Jan 14, 2025
View reviewed changes
packages/store/src/-private/record-arrays/identifier-array.ts Outdated
@@ -396,6 +446,7 @@ export class IdentifierArray<T = unknown> {

const original: StableRecordIdentifier | undefined = target[index];
const newIdentifier = extractIdentifierFromRecord(value);
// FIXME this line was added on main and I'm not sure why
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

investigate v4-main for this

@runspired runspired force-pushed the verify-v4-main branch 7 times, most recently from f8fce9c to bdfc400 Compare January 14, 2025 23:55
@runspired runspired force-pushed the verify-v4-main branch 6 times, most recently from b7e6212 to 5aa4b8c Compare January 15, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
EmberData
Status: needs triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@runspired