Add smoke-tests for types, build, etc

.github/workflows/compat-tests.yml

@@ -83,3 +83,33 @@ jobs:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
       - name: Basic Tests
         run: pnpm test
+
+  packageManagers:
+    name: Smoke test w/ ${{ matrix.packageManager }} & ${{ matrix.kind }}
+    timeout-minutes: 10
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        packageManager:
+        - npm
+        # - yarn # yarn@1 has not been reliable, if yarn@4 were easy to setup, we could test against that
+        - pnpm
+        kind:
+          - alpha # requires unstable-preview-types folder for each package
+          # These aren't ready yet, they require additional folders
+          # - beta # requires preview-types folder for each package
+          # - stable # requires types folder for each package
+
+    steps:
+      - uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4
+      - uses: ./.github/actions/setup
+        with:
+          restore-broccoli-cache: true
+          install: true
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+      - name: "Run a basic smoke test with ${{ matrix.packageManager }} and ${{ matrix.kind }} tagging"
+        run: |
+          bun ./scripts/test-package-manager.mjs \
+            "${{ matrix.packageManager }}" "${{ matrix.kind}}"
+
+

.npmrc

@@ -5,6 +5,7 @@
 # because we have a hoist-pattern. This basically just lets us
 # use the very narrowly scoped hoist-pattern.
 hoist=true
+
 # Fastboot Doesnt respect node_modules resolution for whitelisted deps
 # https://github.com/ember-fastboot/ember-cli-fastboot/issues/901
 hoist-pattern[]=*node-fetch*
@@ -17,7 +18,6 @@ dedupe-peer-dependents=true # this currently introduces more bugs than it fixes
 resolve-peers-from-workspace-root=false # if its not declared we don't want it resolved: ensure tests are truly isolated
 save-workspace-protocol=rolling
 resolution-mode=highest
-dedupe-direct-deps=true
 child-concurrency=10
 ignore-dep-scripts=true
 dedupe-injected-deps=false

package.json

@@ -10,7 +10,7 @@
   "scripts": {
     "takeoff": "FORCE_COLOR=2 pnpm install --prefer-offline --reporter=append-only",
     "prepare": "turbo run build:infra; pnpm --filter './packages/*' run --parallel --if-present sync-hardlinks; turbo run build:pkg; pnpm run prepare:types; pnpm run _task:sync-hardlinks;",
-    "prepare:types": "tsc --build --force; turbo run build:glint;",
+    "prepare:types": "tsc --build --force; turbo run build:glint",
     "release": "./release/index.ts",
     "build": "turbo _build --log-order=stream --filter=./packages/* --concurrency=10;",
     "_task:sync-hardlinks": "pnpm run -r --parallel --if-present sync-hardlinks;",

packages/ember/package.json

@@ -16,7 +16,7 @@
   ],
   "scripts": {
     "_lint": "eslint . --quiet --cache --cache-strategy=content",
-    "build:glint": "glint --build",
+    "build:glint": "glint && glint --build",
     "build:pkg": "vite build;",
     "prepack": "bun run build:pkg",
     "sync-hardlinks": "bun run sync-dependencies-meta-injected"

packages/request/src/-private/context.ts

@@ -159,8 +159,8 @@ export class Context {
   #owner: ContextOwner;
   declare request: ImmutableRequestInfo;
   declare id: number;
-  private declare _isCacheHandler: boolean;
-  private declare _finalized: boolean;
+  declare private _isCacheHandler: boolean;
+  declare private _finalized: boolean;
 
   constructor(owner: ContextOwner, isCacheHandler: boolean) {
     this.id = owner.requestId;

release/core/publish/steps/generate-tarballs.ts

@@ -307,8 +307,34 @@ async function convertTypesToModules(pkg: Package, subdir: 'unstable-preview-typ
   }
 }
 
+function exposeTypes(pkg: Package, subdir: 'unstable-preview-types' | 'preview-types' | 'types') {
+  if (pkg.pkgData.exports) {
+    /**
+     * Allows tsconfig.json#compilerOptions#types to use import paths,
+     * rather than file paths (there are no file path guarantees for any given package manager)
+     */
+    pkg.pkgData.exports[`./${subdir}`] = {
+      /**
+       * No default, import, or require here, because there are no actual modules to import.
+       */
+      types: `./${subdir}/index.d.ts`,
+    };
+
+    /**
+     * For older tsconfig.json settings
+     */
+    pkg.pkgData.typesVersions = {
+      // very loose TS version
+      '*': {
+        [subdir]: [`./${subdir}`],
+      },
+    };
+  }
+}
+
 async function makeTypesAlpha(pkg: Package) {
   scrubTypesFromExports(pkg);
+  exposeTypes(pkg, 'unstable-preview-types');
 
   // enforce that the correct types directory is present
   const present = new Set(pkg.pkgData.files);
@@ -335,6 +361,7 @@ async function makeTypesAlpha(pkg: Package) {
 
 async function makeTypesBeta(pkg: Package) {
   scrubTypesFromExports(pkg);
+  exposeTypes(pkg, 'preview-types');
 
   // enforce that the correct types directory is present
   const present = new Set(pkg.pkgData.files);

release/utils/package.ts

@@ -59,6 +59,7 @@ export type PACKAGEJSON = {
   scripts?: Record<string, string>;
   files?: string[];
   exports?: ExportConfig;
+  typesVersions?: { [tsVersion: string]: { [relativeImportPath: string]: string[] } };
   'ember-addon'?: {
     main?: 'addon-main.js';
     type?: 'addon';