Move generated wasm-pack content to 'node' folder, allowing us to persist a custom index.d.ts #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
fix-the-types
branch
from
27fbdce to
1d3337c
Compare
|
These changes aren't needed because we went with a non-monorepo approach in #44 which included the spirit of these changes anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix our TS situation, and allow all the downstream consumers to not have to copy the types around like here: https://github.com/typed-ember/glint/pull/655/files#diff-0b42acfaca17e97c213ccfa6a2835c25e966bd2bf043799dad69d873828eb368R12
Builds on top of #42