Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal:
Motivation:
How I tested:
npm start
, since we don't have browser tests)yarn link
content-tag
PR on the glint repo in the template-imports workspace andyarn link content-tag
yarn build
in the glint root and check for errors. (At the time of creating this PR there are no errors)Things I encountered:
with the currently published package
which like.. true, because we're using
require
it shouldn't be a module -- at least not an ESM one -- which is how I interpret this -- which may be wrong.In this PR I've just deleted the index.d.cts
I think I had originally thought that the index.d.cts could help with the FalseESM rule, but it did not.
return type of parse is an array, rather than a single object -- this was a bug when the types were introduced
when trying to use standalone.js as the entrypoint for cjs, we correctly get an error from TS