Simplify testing situation to assure import and require works #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this is worth it. There's no reason to think the details of the API would be different between |
NullVoxPopuli
changed the title
|
I don't see the cjs test running in https://github.com/embroider-build/content-tag/actions/runs/7604656450/job/20707813134?pr=59 🤔 |
NullVoxPopuli
force-pushed
the
combine-tests
branch
from
b2909c9 to
7860d98
Compare
ef4
approved these changes
Jan 22, 2024
|
it's sorted |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we don't have duplication.
in a previous attempt
The only thing we need to remember is that we can't directly
requireorimportin module-space in the tests themselves 😅