Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: tests, resolve importSync module resolution issue #2190

Draft
wants to merge 3 commits into
base: v2-addon-type-module-macros-resolve-build
Choose a base branch
from

Conversation

MehulKChaudhari
Copy link

This PR addresses and resolves the failing tests related to importSync and the V2 addon module type. The changes ensure compatibility with ES module imports and correct handling of .js extensions.

Changes made:

  • Updated test import-sync.test.ts file to include .js extensions.
  • Added correct import paths in v2-addon-type-module-test.ts file for ES module compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants