feat: Use XControls in NextQueries and Layout #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check PR 360 preview 👀 |
|
Check PR 360 preview 👀 |
|
Check PR 360 preview 👀 |
|
Check PR 360 preview 👀 |
CachedaCodes
suggested changes
Nov 9, 2023
| * @param storeModule - The {@link XModuleName}. | ||
| * @returns A state object. | ||
| */ | ||
| export function useStore(storeModule?: keyof XModulesTree): RootXStoreState | StatusState { |
There was a problem hiding this comment.
Add a TODO to change when we add the useStore composable in x
Co-authored-by: Guillermo Cacheda <[email protected]>
|
Check PR 360 preview 👀 |
CachedaCodes
approved these changes
Nov 13, 2023
|
Check PR 360 preview 👀 |
CachedaCodes
deleted the
feature/EMP-2722-Use-xControls-in-NQ-and-layout
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
Use XControls to config:
maxNextQueriesPerGroupto be shownMotivation and context
Type of change
What is the destination branch of this PR?
MainHow has this been tested?
Test with
dressanduseXControlscomposable insidecustom-query-preview.vuecomponent to quickly see the changes (you can check this commit to do so)Tests performed according to testing guidelines:
Checklist: