-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate related prompts #516
Conversation
Check PR 516 preview 👀 |
Check PR 516 preview 👀 |
Check PR 516 preview 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!!
Check PR 516 preview 👀 |
'x-staggered-initial', | ||
{ 'x-staggered-animation': isVisible }, | ||
isSelected(index) ? 'x-w-full' : 'x-w-[204px] desktop:x-w-[303px]', | ||
shouldHideButton(index) ? 'x-hidden' : '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldHideButton(index) ? 'x-hidden' : '' | |
{ 'x-hidden': shouldHideButton(index) } |
animation: t calc(var(--n) * 0.05s) steps(var(--n)) forwards; | ||
} | ||
|
||
@keyframes t { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to have a more readable name for the animation 😅
} | ||
|
||
.x-typewritter-animation { | ||
animation: t calc(var(--n) * 0.05s) steps(var(--n)) forwards; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to have a more readable name for the variable --n
|
||
const columns = computed(() => (isMobile.value ? 2 : 4)); | ||
|
||
const isLowResult = computed(() => 0 < x.totalResults && x.totalResults < 50); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lowresults threshold is a config for the semanticQueries module. We could just pick it up from there with const { config } = useState('semanticQueries', ['config']);
Check PR 516 preview 👀 |
Pull request template
Integrate the RelatedPrompts into the archetype.
Missing in this PR: Tagging for RelatedPrompts.
NOTE: As the empathy instance is not generating RP's we are using a store from MotiveMarket for testing purposes.
Motivation and context
Type of change
What is the destination branch of this PR?
Main
How has this been tested?
Tests performed according to testing guidelines:
Checklist: