feat: implement related-prompts multi-query #1685
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegopf
requested changes
Jan 9, 2025
Comment on lines
+15
to
+17
| endpoint: | ||
| 'https://api.empathy.co/relatedprompts/mymotivemarketplace?store=Labstore+London&lang=en', | ||
| requestMapper: ({ query }) => ({ query }), |
There was a problem hiding this comment.
I guess those changes are not intended, are they?
| @@ -66,23 +69,48 @@ | |||
| showOnlyAfterOffset: { | |||
| type: Boolean, | |||
| default: false | |||
| } | |||
| }, | |||
| customQuery: String | |||
There was a problem hiding this comment.
I'd like to avoid custom prefix everything. I think we could just use query for the prop
| () => props.customQuery, | ||
| () => { | ||
| if (props.customQuery || props.customQuery !== '') { | ||
| x.emit('RelatedPromptsCustomQueryProvider', props.customQuery); |
There was a problem hiding this comment.
Following the comment above, I'd like to skip the custom prefix. Besides, we should stick to our convention of using past tense. What about RelatedPromptsQueryProvided?
Comment on lines
77
to
85
| const { query, status } = useState('relatedPrompts', ['query', 'status']); | ||
|
|
||
| /** | ||
| * The state related prompts. | ||
| */ | ||
| const relatedPrompts: ComputedRef<RelatedPrompt[]> = useState('relatedPrompts', [ | ||
| 'relatedPrompts' | ||
| ]).relatedPrompts; | ||
| const relatedPrompts: ComputedRef<Dictionary<RelatedPromptsItems>> = useState( | ||
| 'relatedPrompts', | ||
| ['relatedPrompts'] | ||
| ).relatedPrompts; |
There was a problem hiding this comment.
We could call just once to useState here, right?
| * The current location of the related prompts. | ||
| * Payload: The query to request prompts and the location of the related-prompts. | ||
| */ | ||
| RelatedPromptsLocation: { location: FeatureLocation | undefined; query: string }; |
There was a problem hiding this comment.
I think we don't need this event at all. We could just use UserSelectedARelatedPrompt and rely on the metada. We always provide the location as metadata for the events:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
The idea is to display related prompts from different queries in the same view. For that reason, we have changed the related-prompt structure, now, we are setting the prompts in the state as a dictionary of the queries requested with their corresponding prompts.
We also have to manage the selected prompt view in different locations. For that, we obtain the location of the related prompts from the metadata of the event
UserSelectedARelatedPrompt, which also provides the related prompt query.Motivation and context
Display related-prompts in the toolbar (under the searchbox), and embbed into the results grid.
Type of change
What is the destination branch of this PR?
MainHow has this been tested?
Try with query
trousersin the X demoChecklist: