Opening a directory with O_CREAT should return EISDIR

emscripten-core · Dec 18, 2024 · f78120e · f78120e
1 parent 4ba4c60
commit f78120e
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 11 deletions.
diff --git a/src/library_fs.js b/src/library_fs.js
@@ -426,8 +426,8 @@ FS.staticInit();
       if (FS.isLink(node.mode)) {
         return {{{ cDefs.ELOOP }}};
       } else if (FS.isDir(node.mode)) {
-        if (FS.flagsToPermissionString(flags) !== 'r' || // opening for write
-            (flags & {{{ cDefs.O_TRUNC }}})) { // TODO: check for O_SEARCH? (== search for dir only)
+        if (FS.flagsToPermissionString(flags) !== 'r' // opening for write
+            || (flags & ({{{ cDefs.O_TRUNC }}} | {{{ cDefs.O_CREAT }}}))) { // TODO: check for O_SEARCH? (== search for dir only)
           return {{{ cDefs.EISDIR }}};
         }
       }

diff --git a/test/fcntl/test_fcntl_open.c b/test/fcntl/test_fcntl_open.c
@@ -78,7 +78,7 @@ void test() {
       if ((flags & O_CREAT) && (flags & O_EXCL)) {
         assert(!success);
         assert(errno == EEXIST);
-      } else if ((flags & O_TRUNC) || i != 0 /*mode != O_RDONLY*/) {
+      } else if ((flags & O_TRUNC) || i != 0 /*mode != O_RDONLY*/ || (flags & O_CREAT)) {
         assert(!success);
         assert(errno == EISDIR);
       } else {

diff --git a/test/fcntl/test_fcntl_open.out b/test/fcntl/test_fcntl_open.out
@@ -19,8 +19,8 @@ errno: 0
 st_mode: 0100000
 
 EXISTING FOLDER 0,1
-success: 1
-errno: 0
+success: 0
+errno: 31
 st_mode: 040000
 
 NON-EXISTING 0,1
@@ -139,8 +139,8 @@ errno: 0
 st_mode: 0100000
 
 EXISTING FOLDER 0,9
-success: 1
-errno: 0
+success: 0
+errno: 31
 st_mode: 040000
 
 NON-EXISTING 0,9
@@ -259,8 +259,8 @@ errno: 0
 st_mode: 0100000
 
 EXISTING FOLDER 0,17
-success: 1
-errno: 0
+success: 0
+errno: 31
 st_mode: 040000
 
 NON-EXISTING 0,17
@@ -379,8 +379,8 @@ errno: 0
 st_mode: 0100000
 
 EXISTING FOLDER 0,25
-success: 1
-errno: 0
+success: 0
+errno: 31
 st_mode: 040000
 
 NON-EXISTING 0,25

diff --git a/test/test_core.py b/test/test_core.py
@@ -5545,6 +5545,7 @@ def test_fcntl(self):
     self.add_pre_run("FS.createDataFile('/', 'test', 'abcdef', true, true, false);")
     self.do_run_in_out_file_test('fcntl/test_fcntl.c')
 
+  @also_with_nodefs_both
   def test_fcntl_open(self):
     self.do_run_in_out_file_test('fcntl/test_fcntl_open.c')