Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing options.support_node check when using preload cache #23059

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+14 −5
Open

Add missing options.support_node check when using preload cache #23059

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f12e43
Add missing options.support_node check when using preload cache
Dec 3, 2024
6b19c35
Correct operator
Dec 3, 2024
2d35667
Add test diff created by kripken per request
Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions tools/file_packager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -787,10 +787,13 @@ def generate_js(data_target, data_files, metadata):
var DB_VERSION = 1;
var METADATA_STORE_NAME = 'METADATA';
var PACKAGE_STORE_NAME = 'PACKAGES';
function openDatabase(callback, errback) {
if (isNode) {
return errback();
}
function openDatabase(callback, errback) {'''
if options.support_node:
code += '''
if (isNode) {
return errback();
}'''
code += '''
var indexedDB;
if (typeof window === 'object') {
indexedDB = window.indexedDB || window.mozIndexedDB || window.webkitIndexedDB || window.msIndexedDB;
Expand Down