Remove old warning about firefox bug #23209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firstly the bug has a been fixed. Secondly, the warning is no longer up-to-date with the code and it looks like someone would have to do `-sEXPORT_NAME=moduleArg` to hit this name collision now.. which seems more than unlikely.
kripken
approved these changes
Dec 18, 2024
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
Firstly the bug has a been fixed. Secondly, the warning is no longer up-to-date with the code and it looks like someone would have to do `-sEXPORT_NAME=moduleArg` to hit this name collision now.. which seems more than unlikely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly the bug has a been fixed. Secondly, the warning is no longer up-to-date with the code and it looks like someone would have to do
-sEXPORT_NAME=moduleArgto hit this name collision now.. which seems more than unlikely.