Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ses,pass-style): use non-trapping integrity trait ponyfill for safety #2681

Draft
wants to merge 1 commit into
base: markm-no-trapping-shim
Choose a base branch
from

Conversation

erights
Copy link
Contributor

@erights erights commented Jan 3, 2025

Closes: #XXXX
Refs: #XXXX

Description

Ponyfill-based alternative to #2675

Fails in @endo/cli due to eval twin problems that a ponyfill is subject to, that a shim is not.

Security Considerations

Does this change introduce new assumptions or dependencies that, if violated, could introduce security vulnerabilities? How does this PR change the boundaries between mutually-suspicious components? What new authorities are introduced by this change, perhaps by new API calls?

Scaling Considerations

Does this change require or encourage significant increase in consumption of CPU cycles, RAM, on-chain storage, message exchanges, or other scarce resources? If so, can that be prevented or mitigated?

Documentation Considerations

Give our docs folks some hints about what needs to be described to downstream users. Backwards compatibility: what happens to existing data or deployments when this code is shipped? Do we need to instruct users to do something to upgrade their saved data? If there is no upgrade path possible, how bad will that be for users?

Testing Considerations

Every PR should of course come with tests of its own functionality. What additional tests are still needed beyond those unit tests? How does this affect CI, other test automation, or the testnet?

Compatibility Considerations

Does this change break any prior usage patterns? Does this change allow usage patterns to evolve?

Upgrade Considerations

What aspects of this PR are relevant to upgrading live production systems, and how should they be addressed?

Include *BREAKING*: in the commit message with migration instructions for any breaking change.

Update NEWS.md for user-facing changes.

Delete guidance from pull request description before merge (including this!)

@erights erights self-assigned this Jan 3, 2025
@erights erights changed the base branch from master to markm-no-trapping-shim January 3, 2025 01:45
@erights erights force-pushed the markm-no-trapping-shim branch from d4c5cfb to 4c095c0 Compare January 3, 2025 19:55
@erights erights force-pushed the markm-use-no-trapping-pony branch from 583b2e7 to 0c13733 Compare January 3, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant