Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FBZ-3910] Adds functionality to v6 for sidekiq 6 and later #218

Merged
merged 8 commits into from
Jul 19, 2022

Conversation

mushyy
Copy link
Contributor

@mushyy mushyy commented Oct 30, 2021

No description provided.

Copy link
Contributor

@herbertia herbertia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We upgraded our application to stack v6, ruby 2.7 and Rails 6. Our version of Sidekiq 5.2 was having issue on reloading and we had to migrate to the version 6 of Sidekiq.
As the previous recipe of Sidekiq was not compatible with Sidekiq6 and we needed the recipe urgently, we duplicated your code and make it work.
Here are the modifications we did in order to have the recipe working waiting the official release.

cookbooks/sidekiq6/recipes/cleanup.rb Outdated Show resolved Hide resolved
cookbooks/sidekiq6/recipes/setup.rb Outdated Show resolved Hide resolved
cookbooks/sidekiq6/recipes/setup.rb Outdated Show resolved Hide resolved
cookbooks/sidekiq6/recipes/setup.rb Outdated Show resolved Hide resolved
cookbooks/sidekiq6/templates/default/sidekiq.service.erb Outdated Show resolved Hide resolved
cookbooks/sidekiq6/templates/default/sidekiq.service.erb Outdated Show resolved Hide resolved
@paulasaurus paulasaurus requested a review from kstych January 6, 2022 09:23
Copy link
Contributor

@kstych kstych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the suggested changes incorporated , and confirmation of working recipe , this looks good.

@dvalfre
Copy link
Contributor

dvalfre commented Jul 13, 2022

For the record, this PR addresses issue #214

@dvalfre dvalfre changed the title [WIP] Adds functionality to v6 for sidekiq 6 and later [FBZ-3910] Adds functionality to v6 for sidekiq 6 and later Jul 13, 2022
@dvalfre
Copy link
Contributor

dvalfre commented Jul 13, 2022

Description of your patch

Adds recipes to be able to run Sidekiq 6.

Recommended Release Notes

Adds support for Sidekiq 6.

Estimated risk

Low. The recipes were built specifically for Sidekiq 6 to avoid breaking changes.

Components involved

A new core and custom recipe for Sidekiq 6.

Dependencies

None.

Description of testing done

Booted several environments where the recipe was uploaded and applied.

QA Instructions

  • Choose any application, and record its name.
  • Boot a v6 environment with a utility instance named sidekiq6
  • Add environment variables EY_SIDEKIQ6_ENABLED=TRUE and EY_SIDEKIQ6_INSTANCES_NAME=sidekiq6.
  • Run 'apply' on the environment.
  • SSH into the sidekiq6 instance, run systemctl restart sidekiq_<application_name>_1, where <application_name> is the one recorded above.

@dvalfre dvalfre requested review from kvbautista and removed request for gid-lap July 13, 2022 19:21
Copy link
Contributor

@kvbautista kvbautista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified ey-base/metadata.rb to include sidekiq6 recipe.

Updated cookbooks/sidekiq6/spec/attributes_spec.rb and cookbooks/sidekiq6/spec/setup_spec.rb to includes environment variables for Sidekiq6 (EY_SIDEKIQ6_*)

with the changes above, this looks good to me.

@mushyy mushyy merged commit e5d3834 into next-release Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants