-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FBZ-3910] Adds functionality to v6 for sidekiq 6 and later #218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We upgraded our application to stack v6, ruby 2.7 and Rails 6. Our version of Sidekiq 5.2 was having issue on reloading and we had to migrate to the version 6 of Sidekiq.
As the previous recipe of Sidekiq was not compatible with Sidekiq6 and we needed the recipe urgently, we duplicated your code and make it work.
Here are the modifications we did in order to have the recipe working waiting the official release.
Co-authored-by: Stephanie Rochelemagne <[email protected]>
Co-authored-by: Stephanie Rochelemagne <[email protected]>
Co-authored-by: Stephanie Rochelemagne <[email protected]>
Co-authored-by: Stephanie Rochelemagne <[email protected]>
Signed-off-by: Siddharth <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with the suggested changes incorporated , and confirmation of working recipe , this looks good.
For the record, this PR addresses issue #214 |
Description of your patchAdds recipes to be able to run Sidekiq 6. Recommended Release NotesAdds support for Sidekiq 6. Estimated riskLow. The recipes were built specifically for Sidekiq 6 to avoid breaking changes. Components involvedA new core and custom recipe for Sidekiq 6. DependenciesNone. Description of testing doneBooted several environments where the recipe was uploaded and applied. QA Instructions
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified ey-base/metadata.rb
to include sidekiq6
recipe.
Updated cookbooks/sidekiq6/spec/attributes_spec.rb
and cookbooks/sidekiq6/spec/setup_spec.rb
to includes environment variables for Sidekiq6 (EY_SIDEKIQ6_*
)
with the changes above, this looks good to me.
No description provided.