Remove rules-proto-grpc.com Bazel Rules to lint Protos and gen. MD Doc #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vorburger
changed the title
vorburger
force-pushed
the
rm_rules-proto-grpc.com
branch
from
e6b16a9 to
6278691
Compare
This was (now, after earlier clean-ups) only used to lint Protos and gen. MD Doc. The "value" of that, compared to the "cost" of maintaining (e.g. version bumping) these rules is no longer justified. Thus removing, to simplify.
vorburger
force-pushed
the
rm_rules-proto-grpc.com
branch
from
6278691 to
b171b6a
Compare
e.g. #981 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove use of https://rules-proto-grpc.com
There were (now, after earlier clean-ups) only used to lint Protos and gen. MD Doc.
The "value" of those Bazel rules, compared to the "cost" of maintaining (e.g. version bumping) these rules is no longer justified.
Thus removing, to simplify Enola's build infra (which is far too costly in terms of time consumed).