Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 3 compatibility: django.utils.six has been removed #33

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MarkusShepherd
Copy link

Django 3 removed some Python 2 compatibility libraries which this project depends on, making it impossible right now to upgrade to Django 3.

This PR patches the problem by catching the ImportError and importing six directly instead. It also adds six as a dependency (in the version as it was available in Django 2.2).

A full fix would be to drop six altogether since Python 2 is officially retired now and no longer supported by Django, but this is beyond the scope of this PR.

@codecov-io
Copy link

Codecov Report

Merging #33 into master will decrease coverage by 0.74%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   67.55%   66.81%   -0.75%     
==========================================
  Files           5        5              
  Lines         225      229       +4     
==========================================
+ Hits          152      153       +1     
- Misses         73       76       +3
Impacted Files Coverage Δ
rest_framework_proxy/views.py 69.78% <50%> (-1.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fa51b1...3b9d838. Read the comment docs.

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@1fa51b1). Learn more about missing BASE report.

Files Patch % Lines
rest_framework_proxy/views.py 50.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #33   +/-   ##
=========================================
  Coverage          ?   66.81%           
=========================================
  Files             ?        5           
  Lines             ?      229           
  Branches          ?        0           
=========================================
  Hits              ?      153           
  Misses            ?       76           
  Partials          ?        0           
Files Coverage Δ
rest_framework_proxy/views.py 69.78% <50.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fa51b1...3b9d838. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants