Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Updates: Auth Required, Device Credential Fallback Added, and Error Codes Fixed and Consolidated #83

Merged
merged 2 commits into from
May 25, 2023
Merged

Android Updates: Auth Required, Device Credential Fallback Added, and Error Codes Fixed and Consolidated #83

merged 2 commits into from
May 25, 2023

Conversation

brian-weasner
Copy link
Contributor

@brian-weasner brian-weasner commented Dec 2, 2022

MOST OF THE CHANGES ARE DUE TO THE ADDED .gitignore

Should Fix The Following Issues:

Overview of changes

Breaking!

  • Android
    • If your device has device level credentials, you are required to be authenticated before being able to get/set/delete credentials.
    • Your encypt/decrypt key will become invalided on biometric enrollment changes.
    • Error structure and error codes for verification will be the same as iOS

Thank You

Thank you for making this plugin! Let me know what you think of these changes. If there are any changes you want me to make I will promptly make them so that we can get this merged and deployed quickly.

WIP: Add Android .gitignore
WIP: Android .gitignore is now working
WIP: Android Error Codes, Updates to project level Git Ignore.
WIP: Add iOS .gitignore
WIP: iOS .gitignore is now working
WIP: Android Device Credentials Fallback
WIP: Always Invalidate on biometric enrollment
WIP: Consolidate Error Codes Between iOS and Android
WIP: Fix Swift Issues
WIP: Update comments before submission.
@brian-weasner
Copy link
Contributor Author

Do not merge yet, I found odd error.
After enrolling new biometric, the key becomes invalidated and after I delete the key and re-auth and then create a new key I'm still getting Key user not authenticated

Causing issues where you need to authenticate EVERY time. Only way we would get around this is by adding properties to both the get/set functions because both of them can potentially generate a new key.
@brian-weasner brian-weasner marked this pull request as draft December 7, 2022 19:56
@brian-weasner
Copy link
Contributor Author

I believe some discussion needs to be had about how we want to handle configuration of the Keys.

  1. Do we want to default everyone using this plugin to default to Biometric auth being forced before any get/set/delete of the credentials?

    • I assume we want this to be configurable.
      • What function do we want to use to configure it?
      • If do we want a configuration object that must be provided before any call is made within the plugin?
    • Is there a similar setting for iOS or is this Android Specific?
  2. Similar to the above do we want to force biometric enrollment to automatically invalidate the current encrypt/decrypt key?

    • I assume we want this to be configurable? Via set? Via config?
    • iOS?

@epicshaggy epicshaggy merged commit ce620c8 into epicshaggy:master May 25, 2023
@brian-weasner
Copy link
Contributor Author

Umm, not sure you wanted this to get merged? I set this as a draft due to the error I got regarding the Key user not authenticated #83 (comment)

@brian-weasner
Copy link
Contributor Author

Actually, looking at commit history I removed setUserAuthenticationRequired which is what seemed to be causing the Key user not authenticated error, so this shouldn't break master branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants