feat: Update subnet configuration in main.tf to utilize the 'metal_subnet' variable. #75
Conversation
variables.tf
Outdated
| @@ -31,6 +31,12 @@ variable "metal_project_id" { | |||
| EOT | |||
| } | |||
|
|
|||
| variable "metal_subnet" { | |||
There was a problem hiding this comment.
This PR seems fine except for the name of the variable. The name should match what the CIDR is used for since it is defined in both "metal" (APIs), the basion, and Nutanix.
There was a problem hiding this comment.
Do we need to mention any restrictions on the private subnet that is used or do we expect any RFC1918 subnet to work?
There was a problem hiding this comment.
what is recomended variable name ?
There was a problem hiding this comment.
I'd expect any to work. @cprivitere initially tested with a different CIDR and used this CIDR to match the guides.
There was a problem hiding this comment.
@codinja1188 cluster_cidr ? (something that is not specifically Metal nor Nutanix)
There was a problem hiding this comment.
will go with RF1918, OR RFC6598, check the PR and approve release it, It's really help in VM migration As I mentioned #68 (comment)
There was a problem hiding this comment.
I'll accept metal_subnet as-is.
There was a problem hiding this comment.
Actually, I can't merge this because it does not pass the linter.
variable "metal_subnet" {
- type = string
- default = "192.168.100.0/22"
+ type = string
+ default = "192.168.100.0/22"
description = "nutanix cluster subnet"
}
@codinja1188 If you take this opportunity to rename the field to cluster_subnet, be sure to capture the rename everywhere metal_subnet is used.
There was a problem hiding this comment.
updated in latest commit
Refactor subnet configuration and comments
This commit refactors the subnet configuration in the 'main.tf' file to utilize the 'metal_subnet' variable instead of hardcoding the subnet value. Previously, an arbitrary subnet '192.168.100.0/22' was used directly within the file. By introducing the 'metal_subnet' variable, the configuration becomes more flexible and easier to manage, allowing users to specify their desired subnet for the Nutanix cluster.
Additionally, this commit removes redundant comments related to subnet configuration that were no longer necessary after the refactor. These comments provided guidance on selecting a subnet, which is now handled through the 'metal_subnet' variable, making the comments obsolete.
Overall, this refactor improves the maintainability and flexibility of the Terraform configuration for deploying Nutanix clusters on Equinix Metal infrastructure.