Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fetching map on mission page #1937

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Fix fetching map on mission page #1937

merged 1 commit into from
Jan 8, 2025

Conversation

mrica-equinor
Copy link
Contributor

@mrica-equinor mrica-equinor commented Jan 8, 2025 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@mrica-equinor
Copy link
Contributor Author

mrica-equinor commented Jan 8, 2025 •
edited
Loading

Closes #1936

andchiind
andchiind approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I trust that it has been tested

frontend/src/components/Pages/MissionPage/MapPosition/MissionMapView.tsx Outdated
@@ -48,16 +49,32 @@ export const MissionMapView = ({ mission }: MissionProps) => {

const imageObjectURL = useRef<string>('')

const FetchMapInfo = (mission: Mission) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const FetchMapInfo = (mission: Mission) => {
const fetchMapInfo = (mission: Mission) => {

frontend/src/components/Pages/MissionPage/MapPosition/MissionMapView.tsx
Comment on lines +59 to +60
retryDelay: 60 * 1000,
staleTime: 60 * 1000,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These things should probably be abstracted away, but no need to do it in this PR

Eddasol
Eddasol approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@Eddasol Eddasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT :)

@mrica-equinor mrica-equinor merged commit d72a6c7 into equinor:main Jan 8, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eddasol Eddasol Eddasol approved these changes

@andchiind andchiind andchiind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrica-equinor @andchiind @Eddasol