Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): adds option for --noOpen to not open dev-server in browser #2661

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

eikeland
Copy link
Contributor

Added noOpen option to the development server configuration.

Modified files:

  • packages/cli/src/bin/create-dev-serve.ts
  • packages/cli/src/bin/main.app.ts

Changes:

  • Added noOpen boolean option to createDevServer function.
  • Updated the server configuration to conditionally open the app in the default browser based on the noOpen option.
  • Added -n, --noOpen option to the CLI command for starting the development server.

Copy link

changeset-bot bot commented Dec 19, 2024

🦋 Changeset detected

Latest commit: 436bcdd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@equinor/fusion-framework-cli Patch
@equinor/fusion-framework-cookbook-app-react-context-custom-error Patch
@equinor/fusion-framework-cookbook-app-react-context Patch
@equinor/fusion-framework-cookbook-app-react-feature-flag Patch
poc-portal Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eikeland eikeland self-assigned this Dec 19, 2024
@eikeland eikeland marked this pull request as ready for review December 19, 2024 15:36
@eikeland eikeland requested review from odinr and a team as code owners December 19, 2024 15:36
@github-actions github-actions bot added 💾 CLI fusion framework CLI 🚀 feature New feature or request labels Dec 19, 2024
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.37% 1746 / 464422
🔵 Statements 0.37% 1746 / 464422
🔵 Functions 22.93% 205 / 894
🔵 Branches 36.93% 386 / 1045
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/cli/src/bin/create-dev-serve.ts 0% 0% 0% 0% 1-171
packages/cli/src/bin/main.app.ts 0% 0% 0% 0% 1-270
Generated in workflow #8215 for commit 436bcdd by the Vitest Coverage Report Action

@eikeland eikeland merged commit f60748b into main Dec 19, 2024
9 of 10 checks passed
@eikeland eikeland deleted the feat/cli/noopen-flag branch December 19, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💾 CLI fusion framework CLI 🚀 feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants