Add support for defining pod failure policies for jobs in radixconfig #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nilsgstrabo
commented
Dec 3, 2024
•
nilsgstrabo
commented
- Add failurePolicy configuration to jobs in RA
- Replace incorrect use of "swagger" marker comments with intended markers defined by kubebuilder
- Rewrite unit tests for batch status
- Update building of batch status to support the FailNow policy + hopefully simply the code a bit...
- Add Clock interface to batch syncer to make it easier to test
…policies-for-jobs-in-radixconfig
satr
reviewed
Dec 9, 2024
| radixv1 "github.com/equinor/radix-operator/pkg/apis/radix/v1" | ||
| batchv1 "k8s.io/api/batch/v1" | ||
| ) | ||
|
|
satr
reviewed
Dec 9, 2024
| func hasOneOfConditionTypes(conditionTypes ...batchv1.JobConditionType) func(batchv1.JobCondition) bool { | ||
| return func(condition batchv1.JobCondition) bool { | ||
| return slice.Any(conditionTypes, func(c batchv1.JobConditionType) bool { | ||
| return condition.Type == c && condition.Status == corev1.ConditionTrue |
There was a problem hiding this comment.
From my experience this condition && condition.Status == corev1.ConditionTrue is not always valid for the last condition, remaining forever "False"
satr
requested changes
Dec 9, 2024
satr
approved these changes
Dec 10, 2024
nilsgstrabo
deleted the
1235-add-support-for-defining-pod-failure-policies-for-jobs-in-radixconfig
branch
Richard87
added a commit
that referenced
this pull request
Dec 17, 2024
…y, updated build process (#1254) * feat: Add Healtchchecks to RadixConfig * sync RadixDeployment to KubeDeployment with Healtchchecks * sync RadixApplication to RadixDeployment with Healtchchecks * fix tests * fix linting * Add RA validation * Start testing * replace k8s types with radix, add pointers where optional * bump chart * fix correct error component name * fix correct error component name * Allow redis ports in policy (#1237) * Allow redis ports in policy * Bump chart version * Add support for defining pod failure policies for jobs in radixconfig (#1236) * simplify structures * init commit * bump charts * Build on docker, push same image to all container registries * test workflow on pull (acr tasks should fail) * fix buildx * revert test * push latest tag to ACR * dont export pipeline long tag * configur container image name * simpler validateProbe, remove unneeded tests * fix typo * cleanup * wait 2 minutes * configure buildx platforms * Revert to Registry Cache, push latest operator image * remove unused variable * specify buildcache tag * fix quote sign * fix quote sign * Create a index manifest for the target repo (#1245) * Create a index manifest for the target repo * show progress * Fix typo in buildscript (#1247) * Create a index manifest for the target repo * fix typo * echo out dry-run and push versioned pipeline runner (#1248) * Build and push image to all registries, use cache (#1249) * echo out dry-run and push versioned pipeline runner * Build and push image to all registries, use cache * fix merge conflict (#1250) * Log in to GHCR to enable cache (#1251) * Bump golang.org/x/crypto from 0.26.0 to 0.31.0 (#1246) * fix build process (#1253) --------- Co-authored-by: Nils Gustav Stråbø <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.