Ppx cleanup #1
Open
Ppx cleanup #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an error occurs inside a transaction we need to rsync with the database before proceeding with the rollback. Not doing that will leave the connection in a hung state.
Properly handle transaction errors
Negative offsets were multiplied by 0, and were thus misinterpreted as UTC.
Fix timezone in timestamptz_of_string
These errors are fatal and the connection is immediately closed.
…and. We need to send a Sync message in this case.
Fix synchronization issues after an error
fix comments for ocamldoc
Allow custom unix socket dir as PGHOST
Add some OIDs
fix string escaping
Fix url of postgresql-ocaml
This reverts commit 7fe11fc.
|
Rebased on top of pgocaml master, and re-pushed my branch, so the PR is updated. @eras What do you think of darioteixeira#9 (comment) ? |
Add hex dependency to opam.
Allows building without camlp4 installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch squashes the WIP ppx commits, moves everything on top of pgocaml master, makes pgocaml buildable from a fresh install without camlp4, and makes the ppx tests runnable. Tested to work with OCaml 4.03 up to 4.05, so added opam version constraints for those.
Thanks a lot for doing the work to port pgocaml to ppx!