Improve error message on websocket client close #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the server side prints the error message every time the client sends the Close frame. Since the frame is sent on most connections, this leads to unneccary spam. I haven't tested the http2 variant, but from looking at the code, it follows the same pattern with a different ErrorKind. With the lower priority log level, this can be filtered easily. The distinct messages also help with checking the logs by hand.
|
Thank you ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the server side prints the error message every time the client sends the Close frame. Since the frame is sent on most connections, this leads to unneccary spam. I haven't tested the http2 variant, but from looking at the code, it follows the same pattern with a different ErrorKind.
With the lower priority log level, this can be filtered easily. The distinct messages also help with checking the logs by hand.