Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pdf to png secret #273

Merged
merged 4 commits into from
May 31, 2024
Merged

add pdf to png secret #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
54ee114
import URL secret from vault in deploy job
Studsministern May 31, 2024
913850e
add secret to docker-compose.ci.yml
Studsministern May 31, 2024
c5536c7
update CHANGELOG.md
Studsministern May 31, 2024
ded3983
fix hehe test case
Studsministern May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/docker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ jobs:
kv/data/${{ needs.env-vars.outputs.basename }}/${{ needs.env-vars.outputs.env }} JWT_SECRET;
kv/data/${{ needs.env-vars.outputs.basename }}/${{ needs.env-vars.outputs.env }} EBREV;
kv/data/${{ needs.env-vars.outputs.basename }}/${{ needs.env-vars.outputs.env }} EBREV_API_TOKEN;
kv/data/${{ needs.env-vars.outputs.basename }}/${{ needs.env-vars.outputs.env }} PDF_TO_PNG_BASE_URL;
- name: set variables
run: |
echo "IMAGE_NAME=${{ needs.env-vars.outputs.image_name }}" >> $GITHUB_ENV
Expand Down
3 changes: 2 additions & 1 deletion CHANGELOG.MD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Alla märkbara ändringar ska dokumenteras i denna fil.
Baserat på [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
och följer [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.10.0] - 2024-04-29
## [1.10.0] - 2024-05-31

### Tillagt

Expand All @@ -20,6 +20,7 @@ och följer [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
- Enhetstest för Hehe som kontrollerar att en felaktig filtyp inte kan laddas upp
- Enhetstester för `paginatedHehes`
- Enhetstester för `createPageInfo`
- Environment-variabeln `PDF_TO_PNG_BASE_URL`

### Ändrat

Expand Down
1 change: 1 addition & 0 deletions docker-compose.ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ services:
- JWT_SECRET
- EBREV
- EBREV_API_TOKEN
- PDF_TO_PNG_BASE_URL
networks:
- traefik
- default # to join compose network
Expand Down
3 changes: 1 addition & 2 deletions test/integration/hehe.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { HeheAPI } from '@api/hehe';
import { AccessType, Feature, File, FileType } from '@generated/graphql';
import { removeUploadedFiles, UploadFileOptions, baseUploadFile } from '@test/utils/fileUpload';
import { genRandomUser } from '@test/utils/utils';
import path from 'path';
import request from 'supertest';

const heheApi = new HeheAPI();
Expand Down Expand Up @@ -66,5 +65,5 @@ test('create HeHE cover image from PDF', async () => {
});

// Cover test file must be deleted manually as it is not created by the uploadFile function
fileApi.deleteFile(coverId);
await fileApi.deleteFile(coverId);
});
Loading