Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/verify #275

Merged
merged 7 commits into from
Oct 5, 2024
Merged

Feat/verify #275

merged 7 commits into from
Oct 5, 2024

Conversation

Muncherkin
Copy link
Contributor

Added verification logic to user using a VerifyInfo object for future expansion.
Added connection to verify microservice.
Added automatic verification if user has a post.

!! - - This update is dependent on the same feature in Efterphest and Auth. - - !!

Copy link

github-actions bot commented Sep 9, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 67.84% 1544/2276
🔴 Branches 46.96% 255/543
🔴 Functions 57.36% 265/462
🟡 Lines 67.53% 1466/2171

Test suite run success

255 tests passing in 22 suites.

Report generated by 🧪jest coverage report action from f435cba

@Muncherkin Muncherkin requested a review from pajserman September 9, 2024 09:03
Copy link

github-actions bot commented Sep 9, 2024

I have deployed this PR to feat-verify-ekorre.review.esek.se 🚀

src/api/user.api.ts Outdated Show resolved Hide resolved
Copy link
Member

@afroborg afroborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add some tests for your new api functions pls

@Muncherkin
Copy link
Contributor Author

Made changes after review!

Copy link
Contributor

@pontussjostedt pontussjostedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been reviewed before :)

@pontussjostedt
Copy link
Contributor

LGTM! Reqest solved :)

@pontussjostedt pontussjostedt merged commit c339b45 into main Oct 5, 2024
7 checks passed
Copy link

github-actions bot commented Oct 5, 2024

I have removed this deploy now 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants