-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(console): Added runtime component registration support in console_simple_init #402
Merged
espressif-abhikroy
merged 1 commit into
espressif:master
from
espressif-abhikroy:components/console_simple_init_plugin
Nov 8, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
idf_component_register(SRCS "console_simple_init.c" | ||
INCLUDE_DIRS "." | ||
PRIV_REQUIRES console) | ||
PRIV_REQUIRES console | ||
LDFRAGMENTS linker.lf) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
components/console_simple_init/examples/console_basic/main/idf_component.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
dependencies: | ||
idf: | ||
version: '*' | ||
version: ">=5.0" | ||
console_simple_init: | ||
version: "*" | ||
override_path: '../../../' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
[sections:console_cmd_desc] | ||
entries: | ||
.console_cmd_desc | ||
|
||
[scheme:console_cmd_desc_default] | ||
entries: | ||
console_cmd_desc -> flash_rodata | ||
|
||
[mapping:console_cmd_desc] | ||
archive: * | ||
entries: | ||
* (console_cmd_desc_default); | ||
console_cmd_desc -> flash_rodata KEEP() SORT(name) SURROUND(console_cmd_array) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this potentially links more object files than necessary. We only need to ensure that the component registration callback is linked, but the component may also contain other object files. Following the "user shouldn't pay for what they don't use" principle I think we could try to have a more light-weight solution.
This is probably not a blocker for this PR specifically, we can always update the documentation later. But for other console components you create we might need to revise the WHOLE_ARCHIVE approach. (Also, not a blocker for releasing the first versions.)