[modem]: Refine data -> command transition #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-cermak
force-pushed
the
fix/modem_data_cmd_mode_refine
branch
5 times, most recently
from
e928b51 to
cc1ac2f
Compare
euripedesrocha
approved these changes
Dec 4, 2024
* netif.stop() moved after setting the transition callback * send PPP escape sequence if enabled before waiting for transition to complete * add newline character before sync() command (after the "+++") Closes espressif#692
To avoid issues with IDF_PATH/export with the latest tools
david-cermak
force-pushed
the
fix/modem_data_cmd_mode_refine
branch
from
cc1ac2f to
dbc3ea6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
netif.stop()with setting a callback (to avoid missing the closure)