Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition (also a regression of the PR 19139) #19231

Closed
wants to merge 1 commit into from

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Jan 19, 2025

Fix #19172, which is a regression caused by #19139

I decided to partially rollback 19139 to fix #19172. We need to backport the fix to 3.5, so let's keep it as simple as possible.

We can do any further enhance in 3.6 only.

cc @fuweid @ivanvc @jmhbnz @serathius

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

@ahrtr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-integration-2-cpu-arm64 7e72e74 link true /test pull-etcd-integration-2-cpu-arm64
pull-etcd-integration-4-cpu-arm64 7e72e74 link true /test pull-etcd-integration-4-cpu-arm64
pull-etcd-integration-1-cpu-arm64 7e72e74 link true /test pull-etcd-integration-1-cpu-arm64
pull-etcd-integration-2-cpu-amd64 7e72e74 link true /test pull-etcd-integration-2-cpu-amd64
pull-etcd-integration-4-cpu-amd64 7e72e74 link true /test pull-etcd-integration-4-cpu-amd64
pull-etcd-integration-1-cpu-amd64 7e72e74 link true /test pull-etcd-integration-1-cpu-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.79%. Comparing base (88b3938) to head (7e72e74).

Additional details and impacted files
Files with missing lines Coverage Δ
server/embed/etcd.go 75.73% <ø> (-0.13%) ⬇️

... and 14 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19231      +/-   ##
==========================================
- Coverage   68.87%   68.79%   -0.08%     
==========================================
  Files         420      420              
  Lines       35642    35639       -3     
==========================================
- Hits        24549    24519      -30     
- Misses       9675     9698      +23     
- Partials     1418     1422       +4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b3938...7e72e74. Read the comment docs.

@ahrtr
Copy link
Member Author

ahrtr commented Jan 19, 2025

We can't remove the waitgroup otherwise it may cause another race condition. So we have to follow #19221

@ahrtr ahrtr closed this Jan 19, 2025
@ahrtr ahrtr deleted the race_backport_20250119 branch January 19, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Race condition when closing the embedded etcd
2 participants