-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump github.com/golang-jwt/jwt from v4 to v5 #19232
base: main
Are you sure you want to change the base?
Conversation
dc401fd
to
73ed700
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 18 files with indirect coverage changes @@ Coverage Diff @@
## main #19232 +/- ##
==========================================
- Coverage 68.87% 68.80% -0.08%
==========================================
Files 420 420
Lines 35642 35649 +7
==========================================
- Hits 24549 24528 -21
- Misses 9675 9696 +21
- Partials 1418 1425 +7 Continue to review full report in Codecov by Sentry.
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also link to the existing issue next time when raising PR. Link to #19219 |
Signed-off-by: Matthieu MOREL <[email protected]> Co-authored-by: Benjamin Wang <[email protected]>
cc4f2af
to
52061be
Compare
Hi, this is related to #19219. But it's not the solution to that issue. The solution is to do the 3.5.18 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @mmorel-35. I read the migration guide and verified that our code does not use deprecated or behavioral changes.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc, mmorel-35 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
github.com/golang-jwt/jwt has a v5 that can be used instead of v4
See https://github.com/golang-jwt/jwt/blob/main/MIGRATION_GUIDE.md#migration-guide-v500