Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/golang-jwt/jwt from v4 to v5 #19232

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmorel-35
Copy link
Contributor

Description

github.com/golang-jwt/jwt has a v5 that can be used instead of v4

See https://github.com/golang-jwt/jwt/blob/main/MIGRATION_GUIDE.md#migration-guide-v500

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.80%. Comparing base (88b3938) to head (52061be).
Report is 4 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/auth/jwt.go 79.79% <ø> (ø)
server/auth/options.go 86.79% <ø> (ø)

... and 18 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19232      +/-   ##
==========================================
- Coverage   68.87%   68.80%   -0.08%     
==========================================
  Files         420      420              
  Lines       35642    35649       +7     
==========================================
- Hits        24549    24528      -21     
- Misses       9675     9696      +21     
- Partials     1418     1425       +7     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b3938...52061be. Read the comment docs.

@mmorel-35
Copy link
Contributor Author

/retest

tools/.golangci.yaml Outdated Show resolved Hide resolved
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahrtr
Copy link
Member

ahrtr commented Jan 20, 2025

Also link to the existing issue next time when raising PR.

Link to #19219

Signed-off-by: Matthieu MOREL <[email protected]>

Co-authored-by: Benjamin Wang <[email protected]>
@mmorel-35 mmorel-35 requested a review from ahrtr January 20, 2025 11:43
@ahrtr
Copy link
Member

ahrtr commented Jan 21, 2025

cc @ivanvc @jmhbnz

@ivanvc
Copy link
Member

ivanvc commented Jan 21, 2025

Hi, this is related to #19219. But it's not the solution to that issue. The solution is to do the 3.5.18 release.

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @mmorel-35. I read the migration guide and verified that our code does not use deprecated or behavioral changes.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, mmorel-35

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants