Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for hardcoded flags in TestEtcdServerProcessConfig #19245

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

serathius
Copy link
Member

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.80%. Comparing base (7c56ef2) to head (ce54561).

Additional details and impacted files

see 27 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19245      +/-   ##
==========================================
+ Coverage   68.77%   68.80%   +0.02%     
==========================================
  Files         420      420              
  Lines       35649    35649              
==========================================
+ Hits        24518    24528      +10     
+ Misses       9705     9697       -8     
+ Partials     1426     1424       -2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c56ef2...ce54561. Read the comment docs.

@serathius
Copy link
Member Author

cc @AwesomePatrol

@serathius serathius force-pushed the test-hardcoded-flags branch from a5532d3 to 6ae0e98 Compare January 21, 2025 16:42
@serathius
Copy link
Member Author

/retest

@serathius serathius force-pushed the test-hardcoded-flags branch from 6ae0e98 to 94755e9 Compare January 21, 2025 18:50
@serathius serathius force-pushed the test-hardcoded-flags branch from 94755e9 to ce54561 Compare January 21, 2025 18:57
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(failure is known issue)

@fuweid
Copy link
Member

fuweid commented Jan 21, 2025

/retest

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, serathius, siyuanfoundation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants