-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for hardcoded flags in TestEtcdServerProcessConfig #19245
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 27 files with indirect coverage changes @@ Coverage Diff @@
## main #19245 +/- ##
==========================================
+ Coverage 68.77% 68.80% +0.02%
==========================================
Files 420 420
Lines 35649 35649
==========================================
+ Hits 24518 24528 +10
+ Misses 9705 9697 -8
+ Partials 1426 1424 -2 Continue to review full report in Codecov by Sentry.
|
a5532d3
to
6ae0e98
Compare
/retest |
6ae0e98
to
94755e9
Compare
Signed-off-by: Marek Siarkowicz <[email protected]>
94755e9
to
ce54561
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(failure is known issue)
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid, serathius, siyuanfoundation The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
cc @ahrtr @siyuanfoundation @fuweid