Update scripts/release.sh to push to artifact registry

[jmhbnz]

This pr addresses #15199. On March 18, 2025, Container Registry will be replaced by Artifact Registry and no longer available.

There are wider discussions ongoing about how etcd will adopt/re-use existing k8s etcd image build pipeline. In the short term lets ensure our upcoming releases will push to artifact registry.

A new registry has been created in our etcd-development gcp project: https://console.cloud.google.com/artifacts/docker/etcd-development/us/etcd?project=etcd-development

I have verified push permissions work as expected by pushing a v3.5.17 image to the new repository and granted push permissions to our etcd-release-team custom gcp role. Public read only access has been granted to the repository so users can pull our images.

I've also verified the release script is working as expecting, producing the following images after being run in dry run mode:

 ~  Documents  etcd   main ↑1  last: 0m 6s  docker images
REPOSITORY                                    TAG              IMAGE ID      CREATED             SIZE
gcr.io/etcd-development/etcd                  v3.6.99-s390x    0955597f3106  35 seconds ago      64.4 MB
quay.io/coreos/etcd                           v3.6.99-s390x    0955597f3106  35 seconds ago      64.4 MB
us-docker.pkg.dev/etcd-development/etcd/etcd  v3.6.99-s390x    0955597f3106  35 seconds ago      64.4 MB
gcr.io/distroless/static-debian12             <none>           4d0de7b4ef96  37 seconds ago      5.73 MB
us-docker.pkg.dev/etcd-development/etcd/etcd  v3.6.99-ppc64le  28c366e5d9ad  50 seconds ago      60.5 MB
quay.io/coreos/etcd                           v3.6.99-ppc64le  28c366e5d9ad  50 seconds ago      60.5 MB
gcr.io/etcd-development/etcd                  v3.6.99-ppc64le  28c366e5d9ad  50 seconds ago      60.5 MB
gcr.io/etcd-development/etcd                  v3.6.99-arm64    619e0640fca5  About a minute ago  59 MB
quay.io/coreos/etcd                           v3.6.99-arm64    619e0640fca5  About a minute ago  59 MB
us-docker.pkg.dev/etcd-development/etcd/etcd  v3.6.99-arm64    619e0640fca5  About a minute ago  59 MB
us-docker.pkg.dev/etcd-development/etcd/etcd  v3.6.99-amd64    5cc288184af8  About a minute ago  60.9 MB
gcr.io/etcd-development/etcd                  v3.6.99-amd64    5cc288184af8  About a minute ago  60.9 MB
quay.io/coreos/etcd                           v3.6.99-amd64    5cc288184af8  About a minute ago  60.9 MB

cc @ahrtr, @serathius, @ivanvc

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.75%. Comparing base (83771ff) to head (0dd4344).

Additional details and impacted files

see 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19250      +/-   ##
==========================================
- Coverage   68.81%   68.75%   -0.07%     
==========================================
  Files         420      420              
  Lines       35649    35649              
==========================================
- Hits        24533    24509      -24     
- Misses       9691     9715      +24     
  Partials     1425     1425              

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83771ff...0dd4344. Read the comment docs.

[jmhbnz]

/test pull-etcd-integration-2-cpu-amd64

[ivanvc]

LGTM. Thanks, James. From the conversation, it sounds like a blocker before the script's execution time. Given GCR's deprecation, that should not be a blocker anymore.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jmhbnz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[serathius]

https://cloud.google.com/artifact-registry/docs/transition/auto-migrate-gcr-ar#migrate-gcrio-hosted-ar mentions Redirects all traffic from gcr.io endpoint to Artifact Registry. Do we really need to change the script to have a separate image push to AR assuming that redirect will work?

[jmhbnz]

https://cloud.google.com/artifact-registry/docs/transition/auto-migrate-gcr-ar#migrate-gcrio-hosted-ar mentions Redirects all traffic from gcr.io endpoint to Artifact Registry. Do we really need to change the script to have a separate image push to AR assuming that redirect will work?

We don't need to. However adopting the new pkg.dev hosts provides more features and appears to be the long term direction for Google, so if we are going to migrate my vote would be to do it fully: https://cloud.google.com/artifact-registry/docs/transition/transition-from-gcr#feature-comparison.