Align NewConfig with AddFlags defaults

[serathius]

cc @ahrtr @fuweid @AwesomePatrol @siyuanfoundation

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ahrtr]

We need to update the default value in AddFlags: change the 1 with cfg.SelfSignedCertValidity. This comment applies other fields as well.

etcd/server/embed/config.go

Line 734 in c9045d6

fs.UintVar(&cfg.SelfSignedCertValidity, "self-signed-cert-validity", 1, "The validity period of the client and peer certificates, unit is year")

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.80%. Comparing base (8c1547b) to head (5a556d8).
Report is 2 commits behind head on main.

Additional details and impacted files

Files with missing lines	Coverage Δ
server/embed/config.go	79.47% <100.00%> (-0.03%)	⬇️

... and 29 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19254      +/-   ##
==========================================
+ Coverage   68.79%   68.80%   +0.01%     
==========================================
  Files         420      420              
  Lines       35649    35669      +20     
==========================================
+ Hits        24524    24542      +18     
+ Misses       9698     9697       -1     
- Partials     1427     1430       +3     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c1547b...5a556d8. Read the comment docs.