Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New solution] Fix race condition (also a regression of the PR 19139) #19257

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Jan 22, 2025

Fix #19172

Original solution: #19221

cc @serathius @fuweid

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.85%. Comparing base (363b166) to head (f330406).

Files with missing lines Patch % Lines
server/embed/etcd.go 77.77% 4 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/embed/serve.go 59.38% <100.00%> (ø)
server/embed/etcd.go 76.49% <77.77%> (+0.29%) ⬆️

... and 26 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19257      +/-   ##
==========================================
+ Coverage   68.83%   68.85%   +0.02%     
==========================================
  Files         420      420              
  Lines       35670    35673       +3     
==========================================
+ Hits        24552    24563      +11     
+ Misses       9697     9690       -7     
+ Partials     1421     1420       -1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 363b166...f330406. Read the comment docs.

server/embed/etcd.go Outdated Show resolved Hide resolved
Signed-off-by: Benjamin Wang <[email protected]>
@ahrtr
Copy link
Member Author

ahrtr commented Jan 22, 2025

cc. @fuweid @serathius PTAL

This PR is only for main branch, no backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Race condition when closing the embedded etcd
3 participants