close client and metrics listeners firstly when shutting down etcd
Codecov / codecov/project
succeeded
Jan 20, 2025 in 0s
68.82% (+0.09%) compared to bae527c
View this Pull Request on Codecov
68.82% (+0.09%) compared to bae527c
Details
Codecov Report
Attention: Patch coverage is 74.07407% with 7 lines in your changes missing coverage. Please review.
Project coverage is 68.82%. Comparing base (
bae527c) to head (86ce681).
Report is 2 commits behind head on main.
❗ Current head 86ce681 differs from pull request most recent head 32fb3ee
Please upload reports for the commit 32fb3ee to get more accurate results.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| server/embed/etcd.go | 63.63% | 3 Missing and 1 partial |
| server/embed/serve.go | 81.25% | 1 Missing and 2 partials |
Additional details and impacted files
| Files with missing lines | Coverage Δ | |
|---|---|---|
| server/embed/serve.go | 59.38% <81.25%> (+1.58%) |
⬆️ |
| server/embed/etcd.go | 76.19% <63.63%> (+0.33%) |
⬆️ |
... and 17 files with indirect coverage changes
@@ Coverage Diff @@
## main #19221 +/- ##
==========================================
+ Coverage 68.73% 68.82% +0.09%
==========================================
Files 420 420
Lines 35642 35657 +15
==========================================
+ Hits 24497 24541 +44
+ Misses 9720 9694 -26
+ Partials 1425 1422 -3 Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update bae527c...32fb3ee. Read the comment docs.
Loading