better error handling for invalid api response

ethancedwards8 · Jan 6, 2025 · 7f36f1c · 7f36f1c
1 parent 1aea931
commit 7f36f1c
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/pages/index.js b/pages/index.js
@@ -58,12 +58,15 @@ export async function getServerSideProps() {
 
     const posts = getAllPosts();
 
-    await fetch(`https://api.ethancedwards.com/quotes/v1`).then((res) => {
-            final = res;
-        }).catch((error) => {
-            quotes = { quote: "Value your freedom or you will lose it, teaches history", author: "Richard Stallman" };
+    // await fetch(`https://api.ethancedwards.com/quotes/v1`).then((res) => {
+    await fetch(`http://localhost/quotes/v1`).then((res) => {
+            if (!res.ok) {
+                final = { quote: "Value your freedom or you will lose it, teaches history", author: "Richard Stallman" };
+            } else {
+                final = res.json();
+            }
         });
-    quotes = await final.json();
+    quotes = await final;
 
     return { props: { quotes, posts } };
 }