Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check for minimum anvil version #47

Merged
merged 1 commit into from
Jul 13, 2024
Merged

feat: check for minimum anvil version #47

merged 1 commit into from
Jul 13, 2024

Conversation

tremarkley
Copy link
Contributor

@tremarkley tremarkley commented Jul 11, 2024

Closes #38

Implements a check that the machine has a minimum anvil version of 0.2.0 (2024-07-12T00:22:06.921038000Z) installed prior to starting supersim.

@tremarkley
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tremarkley and the rest of your teammates on Graphite Graphite

@tremarkley tremarkley force-pushed the harry/min_anvil branch 4 times, most recently from bdcb0c5 to e6838b0 Compare July 11, 2024 23:50
@tremarkley tremarkley marked this pull request as ready for review July 11, 2024 23:52
@tremarkley tremarkley requested a review from a team as a code owner July 11, 2024 23:52
Copy link
Contributor

@jakim929 jakim929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foundry doesn't follow semver until 1.0.0 is released
https://github.com/foundry-rs/foundry/blob/5b8416363c7c1aab6d3cda0da6e7c65594ad8a12/CHANGELOG.md

so 0.2.0 has been around for more than a year and covers a huge range of releases.

foundryup installs the latest nightly release. It might make more sense to check that the timestamp on the nightly release is past a certain minimum version.
anvil 0.2.0 (0116be1 2024-07-09T00:18:45.485630000Z)

Not sure what the minimum version we are trying to enforce is though.

since they only keep around nightly releases at the beginning of the month (foundry-rs/foundry#4558), would make sense to set it to that so users can go install a previous version if necessary.

cmd/main.go Outdated Show resolved Hide resolved
cmd/main.go Outdated Show resolved Hide resolved
@tremarkley tremarkley force-pushed the harry/min_anvil branch 2 times, most recently from a57d1ba to 1fc586b Compare July 12, 2024 22:14
@tremarkley tremarkley requested a review from jakim929 July 12, 2024 22:15
@tremarkley tremarkley merged commit d341956 into main Jul 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

supersim: on startup check that required version of anvil is installed
2 participants